Re: [PATCH v2 3/3] mmc: mediatek: add support for SDIO eint irq

From: Andy Shevchenko
Date: Thu Jan 13 2022 - 05:49:16 EST


On Thu, Jan 13, 2022 at 03:58:52PM +0800, Axe Yang wrote:

> But for the comment for 'dev_dbg', can you explain more about that?

Sure.

> On Tue, 2022-01-11 at 13:46 +0200, Andy Shevchenko wrote:
> > On Tue, Jan 11, 2022 at 09:40:46AM +0800, Axe Yang wrote:

...

> > > + host->pins_eint = pinctrl_lookup_state(host->pinctrl,
> > > "state_eint");
> > > + if (IS_ERR(host->pins_eint)) {
> > > + dev_dbg(&pdev->dev, "Cannot find pinctrl
> > > eint!\n");
> >
> > In debug mode of pin control this will bring a duplicate message.
>
> Can you explain more about this comment?
> I don't understand what the 'duplicate message' refers for.

Have you chance to read the implementation of pinctrl_lookup_state()?

--
With Best Regards,
Andy Shevchenko