Re: [Linux-cachefs] [PATCH v1 05/23] netfs: add inode parameter to netfs_alloc_read_request()

[Gao Xiang]

On Thu, Jan 13, 2022 at 11:10:57AM +0800, JeffleXu wrote:
> Hi David,
> 
> What would you think about this cleanup? We need this in prep for the
> following fscache-based on-demand reading feature. It would be great if
> it could be cherry picked in advance.
> 
> I also simplify the commit message as suggested by Gao Xiang. I could
> resend a v2 patch with the updated commit message if you'd like.
> 
>     netfs: add inode parameter to netfs_alloc_read_request()
> 
>     Make the @file parameter optional, and derive inode from the @folio
>     parameter instead.
> 
>     @file parameter can't be removed completely, since it also works as
>     the private data of ops->init_rreq().
> 
>     Signed-off-by: Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx>

Hi,

IMHO, How about the following message:

netfs: make @file optional in netfs_alloc_read_request()

Make the @file parameter optional, and derive inode from the @folio
parameter instead in order to support file system internal requests.

@file parameter can't be removed completely, since it also works as
the private data of ops->init_rreq().

Thanks,
Gao Xiang