Re: [PATCH net] net/smc: Avoid setting clcsock options after clcsock released

[Wen Gu]

On 2022/1/12 5:38 pm, Karsten Graul wrote:
> On 11/01/2022 17:34, Wen Gu wrote:
> > Thanks for your reply.
> >
> > On 2022/1/11 6:03 pm, Karsten Graul wrote:
> > > On 10/01/2022 10:38, Wen Gu wrote:
> > > > We encountered a crash in smc_setsockopt() and it is caused by
> > > > accessing smc->clcsock after clcsock was released.
> > >
> > > In the switch() the function smc_switch_to_fallback() might be called which also
> > > accesses smc->clcsock without further checking. This should also be protected then?
> > > Also from all callers of smc_switch_to_fallback() ?
>
> Lets go with your initial patch (improved to address the access in smc_switch_to_fallback())
> for now because it solves your current problem.

Since the upcoming v2 patch added clcsock check in smc_switch_to_fallback(),
the original subject is inappropriate.

So I sent a new patch named 'net/smc: Transitional solution for clcsock race issue'
instead of a v2.

Thanks,
Wen Gu