Re: [PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c

From: Song Liu
Date: Thu Jan 13 2022 - 12:07:48 EST


On Wed, Jan 12, 2022 at 7:17 PM <menglong8.dong@xxxxxxxxx> wrote:
>
> From: Menglong Dong <imagedong@xxxxxxxxxxx>
>
> 'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not
> used, just remove them.
>
> Signed-off-by: Menglong Dong <imagedong@xxxxxxxxxxx>

Acked-by: Song Liu <songliubraving@xxxxxx>

> ---
> tools/testing/selftests/bpf/progs/sockmap_parse_prog.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> index 95d5b941bc1f..c9abfe3a11af 100644
> --- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> +++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> @@ -7,8 +7,6 @@ int bpf_prog1(struct __sk_buff *skb)
> {
> void *data_end = (void *)(long) skb->data_end;
> void *data = (void *)(long) skb->data;
> - __u32 lport = skb->local_port;
> - __u32 rport = skb->remote_port;
> __u8 *d = data;
> int err;
>
> --
> 2.34.1
>