Re: [PATCH v1 8/9] drivers: hv: dxgkrnl: Implement various WDDM ioctls

From: Iouri Tarassov
Date: Thu Jan 13 2022 - 19:19:44 EST



On 1/12/2022 11:47 PM, Greg KH wrote:
On Wed, Jan 12, 2022 at 11:55:13AM -0800, Iouri Tarassov wrote:
> Implement various WDDM IOCTLs.
> Again, break this up into smaller pieces. Would you want to review all
of these at the same time?

Remember, you write code for people to review and understand first, and
the compiler second. With large changes like this, you are making it
difficult for people to review, which is your target audience.

I'll stop here, please fix up this patch series into something that is
reviewable.

Hi Greg,

https://www.kernel.org/doc/html/latest/process/submitting-patches.html
states that "only post say 15 [patches] or so at a time and wait for review and integration".
The IOCTLs here are simple and I tried to keep the number of patches smaller
than 15. Is it ok to have more than 15 patches in a submission, or I need to
submit the driver is several chunks (some of which would be not fully functional)?

Thanks
Iouri