Re: [PATCH v2 2/2] selftests: add option to list all available tests

[lizhijian@xxxxxxxxxxx]

On 13/01/2022 23:21, David Ahern wrote:
> On 1/12/22 10:53 PM, lizhijian@xxxxxxxxxxx wrote:
>> ping
> seems to have been lost in the void
>
>>
>> On 02/12/2021 10:29, Li Zhijian wrote:
>>> $ ./fcnal-test.sh -l
>>> Test names: ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter
>>> ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter
>>> use_cases
>>>
>>> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxxxxx>
>>> ---
>>>    tools/testing/selftests/net/fcnal-test.sh | 9 ++++++++-
>>>    1 file changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
>>> index 5cb59947eed2..7e78be99aa4c 100755
>>> --- a/tools/testing/selftests/net/fcnal-test.sh
>>> +++ b/tools/testing/selftests/net/fcnal-test.sh
>>> @@ -3993,6 +3993,7 @@ usage: ${0##*/} OPTS
>>>    	-4          IPv4 tests only
>>>    	-6          IPv6 tests only
>>>    	-t <test>   Test name/set to run
>>> +	-l          List all available tests
>>>    	-p          Pause on fail
>>>    	-P          Pause after each test
>>>    	-v          Be verbose
>>> @@ -4006,10 +4007,15 @@ TESTS_IPV4="ipv4_ping ipv4_tcp ipv4_udp ipv4_bind ipv4_runtime ipv4_netfilter"
>>>    TESTS_IPV6="ipv6_ping ipv6_tcp ipv6_udp ipv6_bind ipv6_runtime ipv6_netfilter"
>>>    TESTS_OTHER="use_cases"
>>>    
>>> +list()
>>> +{
>>> +	echo "Test names: $TESTS_IPV4 $TESTS_IPV6 $TESTS_OTHER"
>>> +}
> Just add the test list at the end of usage() like this:
it sounds good

Thanks
Zhijian
>
> @@ -4019,6 +4019,9 @@ usage: ${0##*/} OPTS
>          -p          Pause on fail
>          -P          Pause after each test
>          -v          Be verbose
> +
> +Tests:
> +       $TESTS_IPV4 $TESTS_IPV6 $TESTS_OTHER
>   EOF
>   }
>
>
>