Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build

From: Stephen Boyd
Date: Thu Jan 13 2022 - 21:11:36 EST


Quoting Miles Chen (2022-01-10 09:09:59)
> To support COMMON_CLK_MT8192* module build,
> add MODULE_LICENSE and include module.h.
>
> Cc: Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx>
> Cc: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
> Signed-off-by: Miles Chen <miles.chen@xxxxxxxxxxxx>

Have you tried removing the modules? And then reloading them? I also see
that mtk_clk_simple_probe() doesn't actually unregister anything, it
just frees some allocations. Please fix this before making these
modules.