Re: [PATCH] nvme: Mark external NVMe devices as removable

[Kai-Heng Feng]

On Fri, Jan 14, 2022 at 12:12 AM Keith Busch <kbusch@xxxxxxxxxx> wrote:
>
> On Thu, Jan 13, 2022 at 02:39:02PM +0800, Kai-Heng Feng wrote:
> > On Wed, Jan 12, 2022 at 10:03 PM Christoph Hellwig <hch@xxxxxx> wrote:
> > >
> > > On Wed, Jan 12, 2022 at 08:50:33PM +0800, Kai-Heng Feng wrote:
> > > > USB thumb drives also use this flag, so I am not sure why it's not
> > > > applicable to NVMe?
> > >
> > > They shouldn't report this flag and might need fixing.
> >
> > So what should we do? Introduce a different flag but with identical
> > usage for external USB and NVMe storages?
>
> What's the user visible result with this flag set? Does some rule
> automatically mount a 'removable' block device's filesystem partitions
> to something like /media/?

Udisks uses 'removable' to flag its 'HintAuto' attribute, and GNOME
Shell will automount the disk based on 'HintAuto'.

Kai-Heng