Re: mlx5: memory leaks

[Leon Romanovsky]

On Thu, Jan 13, 2022 at 12:37:10PM +0800, Ryan Cai wrote:
> Hi, Kernel Maintainers,
> 
>     In method mlx5_ib_destroy_gsi of gsi.c, there are memory leaks when ret = ib_destroy_qp(gsi->rx_qp); returns true? I think, ib_free_cq(gsi->cq); kfree(gsi->outstanding_wrs); kfree(gsi->tx_qps); should also be put before return ret before Line 180. If this is a real bug, I can send a patch. Thanks!

The ib_destroy_qp() is function that destroys kernel QP that in our
memory model shouldn't fail. The patch that converts ib_destroy_qp()
to be void is very welcomed.

See ib_destroy_srq() as an example of expected function format.

Thanks