Re: [PATCH 3/4] arm64: dts: qcom: sc7280: Factor out Chrome common fragment

From: Matthias Kaehlcke
Date: Fri Jan 14 2022 - 09:24:54 EST


On Thu, Jan 13, 2022 at 04:43:02PM -0800, Douglas Anderson wrote:
> This factors out a device tree fragment from some sc7280 device
> trees. It represents the device tree bits that should be included for
> "Chrome" based sc7280 boards. On these boards the bootloader (Coreboot
> + Depthcharge) configures things slightly different than the
> bootloader that Qualcomm provides. The modem firmware on these boards
> also works differently than on other Qulacomm products and thus the
> reserved memory map needs to be adjusted.
>
> NOTES:
> - This is _not_ quite a no-op change. The "herobrine" and "idp"
> fragments here were different and it looks like someone simply
> forgot to update the herobrine version. This updates a few numbers
> to match IDP. This will also cause the `pmk8350_pon` to be disabled
> on idp/crd, which I belive is a correct change.
> - At the moment this assumes LTE skus. Once it's clearer how WiFi SKUs
> will work (how much of the memory map they can reclaim) we may add
> an extra fragment that will rejigger one way or the other.
>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>