Re: [PATCH v2] scripts/dtc: dtx_diff: remove broken example from help text
From: Rob Herring
Date: Fri Jan 14 2022 - 10:26:11 EST
On Thu, Jan 13, 2022 at 09:19:18AM +0100, Matthias Schiffer wrote:
> dtx_diff suggests to use <(...) syntax to pipe two inputs into it, but
> this has never worked: The /proc/self/fds/... paths passed by the shell
> will fail the `[ -f "${dtx}" ] && [ -r "${dtx}" ]` check in compile_to_dts,
> but even with this check removed, the function cannot work: hexdump will
> eat up the DTB magic, making the subsequent dtc call fail, as a pipe
> cannot be rewound.
>
> Simply remove this broken example, as there is already an alternative one
> that works fine.
>
> Fixes: 10eadc253ddf ("dtc: create tool to diff device trees")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxxxxx>
> ---
> scripts/dtc/dtx_diff | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Applied, thanks.
Rob