Re: drivers/firmware/efi/sysfb_efi.c:190:35: warning: unused variable 'efifb_dmi_system_table'

[Randy Dunlap]

Hi lkp robot,

I have a metaquestion, please:


On 1/4/22 03:52, kernel test robot wrote:
> Hi Randy,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   c9e6606c7fe92b50a02ce51dda82586ebdf99b48
> commit: 15d27b15de965043d6f8e23bc7f34386fcd1a772 efi: sysfb_efi: fix build when EFI is not set
> date:   5 months ago
> config: x86_64-randconfig-a016-20210927 (https://download.01.org/0day-ci/archive/20220104/202201041920.mOzzco4D-lkp@xxxxxxxxx/config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=15d27b15de965043d6f8e23bc7f34386fcd1a772
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 15d27b15de965043d6f8e23bc7f34386fcd1a772
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/firmware/efi/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/firmware/efi/sysfb_efi.c:72:6: warning: no previous prototype for function 'efifb_setup_from_dmi' [-Wmissing-prototypes]
>    void efifb_setup_from_dmi(struct screen_info *si, const char *opt)
>         ^
>    drivers/firmware/efi/sysfb_efi.c:72:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    void efifb_setup_from_dmi(struct screen_info *si, const char *opt)
>    ^
>    static 
>>> drivers/firmware/efi/sysfb_efi.c:190:35: warning: unused variable 'efifb_dmi_system_table' [-Wunused-const-variable]
>    static const struct dmi_system_id efifb_dmi_system_table[] __initconst = {
>                                      ^
>>> drivers/firmware/efi/sysfb_efi.c:240:35: warning: unused variable 'efifb_dmi_swap_width_height' [-Wunused-const-variable]
>    static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
>                                      ^
>>> drivers/firmware/efi/sysfb_efi.c:331:39: warning: unused variable 'efifb_fwnode_ops' [-Wunused-const-variable]
>    static const struct fwnode_operations efifb_fwnode_ops = {
>                                          ^
>    4 warnings generated.
> 
> 
> vim +/efifb_dmi_system_table +190 drivers/firmware/efi/sysfb_efi.c
> 

[snip]

Why is the patch committer (David Herrmann) not cc-ed on your original email?
(I am adding him now.)

bu I have seen this multiple times, where the TO: person (below) is not cc-ed
on the problem email.  I don't understand.

> 
> :::::: The code at line 190 was first introduced by commit
> :::::: 2995e506276bfdc7311eb02db8b2aa1a61a4b849 x86: sysfb: move EFI quirks from efifb to sysfb
> 
> :::::: TO: David Herrmann <dh.herrmann@xxxxxxxxx>
> :::::: CC: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

thanks.
-- 
~Randy