Re: [PATCHv6 4/5] tracing: Add register read/write tracing support

[Sai Prakash Ranjan]

On 1/8/2022 11:04 AM, Sai Prakash Ranjan wrote:
> Hi,
>
> On 1/7/2022 8:26 PM, Steven Rostedt wrote:
> > On Fri, 7 Jan 2022 10:40:05 +0530
> > Sai Prakash Ranjan <quic_saipraka@xxxxxxxxxxx> wrote:
> >
> > > Hi Steve,
> > >
> > > On 1/6/2022 11:48 PM, Steven Rostedt wrote:
> > > > This should not be in the kernel/trace directory. It should be in the
> > > Hmm these are called from low level generic io header file
> > > (include/asm-generic/) where
> > > we wouldn't have any Kconfig to control this feature flexibly and as we
> > > can have this as
> > > a generic feature selectable by other architectures, wouldn't this be
> > > suited in kernel/trace?
> > Isn't there a place for generic rwmmio code?
>
> I am thinking of moving it to lib/ similar to an interface of 
> logic_iomem.c which
> Arnd had initially suggested to look at.
>
> > > I thought you were ok with the folder structure in the initial versions
> > > of the series?
> > Sorry, I missed the C file in kernel/trace. The files in kernel/trace 
> > tend
> > to be specific for the internals of tracing. This C file is more to hold
> > helper functions for mmio, which to me should be someplace for mmio 
> > code.
> > Perhaps in mm/ ?
>
> Oh ok, mm would not be the right fit as it is memory management and 
> this is about
> memory mapped IO, let me try and move it to lib/ as done for 
> logic_iomem.c
>
> Thanks,
> Sai

Posted v7 - 
https://lore.kernel.org/lkml/cover.1642233364.git.quic_saipraka@xxxxxxxxxxx/

Thanks,
Sai