Re: [PATCH v2 0/3] Add initial support for exynos5420-chagallwifi

From: Krzysztof Kozlowski
Date: Sat Jan 15 2022 - 11:37:38 EST


On 15/01/2022 17:27, Henrik Grimler wrote:
> Samsung's tablet Galaxy Tab S 10.5" (wifi) has codename chagallwifi
> and is one of several tablets released in 2013 - 2014 based on Exynos
> 5420. This initial devicetree adds support for accessing device over
> USB or UART, and allows using a rootfs in either the internal eMMC or
> an external sdcard. 4 out of 8 CPUs are brought up when device boots,
> which is the same as on the somewhat similar device
> exynos5420-arndale-octa.
>
> Patch 2 is necessary after a secure-firmware node is added, otherwise
> device hangs during the CPU1BOOT secure monitor call. Without the
> secure-firmware node we are not able to bring up any secondary CPUs.
>
> Changes since v1
> ================
>
> Fix mmc_0 and usbdrd in patch 3:
> * Remove extra, non supported, options from mmc_0 node
> * Do not set usbdrd supplies. Usb networking does not work with them
> specified, but it works fine with dummy regulators

Re-try with supplies after fixing the regulators (my comment to v1).
These should work, unless your regulators are wrongly configured or you
used wrong supplies.

I just sent a review for v1, so please go through it.

Best regards,
Krzysztof