Re: [PATCH v8 4/4] m68k: introduce a virtual m68k machine

[Geert Uytterhoeven]

Hi Laurent,

On Sat, Jan 15, 2022 at 8:33 PM Laurent Vivier <laurent@xxxxxxxxx> wrote:
> This machine allows to have up to 3.2 GiB and 128 Virtio devices.
>
> It is based on android goldfish devices.
>
> Signed-off-by: Laurent Vivier <laurent@xxxxxxxxx>

Thanks for your patch (the new versions keep on coming quickly).

> --- /dev/null
> +++ b/arch/m68k/virt/platform.c

> +static int __init virt_platform_init(void)
> +{
> +       const struct resource goldfish_tty_res[] = {
> +               DEFINE_RES_MEM(virt_bi_data.tty.mmio, 1),
> +               DEFINE_RES_IRQ(virt_bi_data.tty.irq),
> +       };
> +       /* this is the second gf-rtc, the first one is used by the scheduler */
> +       const struct resource goldfish_rtc_res[] = {
> +               DEFINE_RES_MEM(virt_bi_data.rtc.mmio + 0x1000, 0x1000),
> +               DEFINE_RES_IRQ(virt_bi_data.rtc.irq + 1),
> +       };
> +       extern unsigned long min_low_pfn;

checkpatch keeps on complaining.
#include <linux/memblock.h> instead?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds