Re: [PATCH 5/7] random: rather than entropy_store abstraction, use global

From: Dominik Brodowski
Date: Sun Jan 16 2022 - 08:45:35 EST


> -static void __mix_pool_bytes(struct entropy_store *r, const void *in,
> - int nbytes)
> +static void __mix_pool_bytes(const void *in, int nbytes)
> {
> - trace_mix_pool_bytes_nolock(r->name, nbytes, _RET_IP_);
> - _mix_pool_bytes(r, in, nbytes);
> + trace_mix_pool_bytes_nolock(nbytes, _RET_IP_);
> + _mix_pool_bytes(in, nbytes);

Can the parameters of these tracepoints be modified, or does this break
any part of our API?

I haven't looked at the tracepoint bits in detail; otherwise, the changes
look good:

Reviewed-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> # random.c only

Thanks,
Dominik