Re: [PATCH v2] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb

From: Javier Martinez Canillas
Date: Sun Jan 16 2022 - 12:31:33 EST


On 1/16/22 13:16, Miaoqian Lin wrote:
> Add the missing platform_device_put() before return from
> sysfb_create_simplefb() in the error handling case.
>
> Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> ---
> Changes in v2:
> - Use goto label to avoid duplicating the error code logic.
> ---
> drivers/firmware/sysfb_simplefb.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat