Re: [PATCH v2 0/2] Clock based PWM output driver

[Nikita Travkin]

Uwe Kleine-König писал(а) 17.01.2022 17:10:
> Hello Nikita,
> 
> On Mon, Dec 13, 2021 at 08:03:33PM +0500, Nikita Travkin wrote:
>> This series introduces an "adapter" driver that allows PWM consumers
>> to control clock outputs with duty-cycle control.
>>
>> Some platforms (e.g. some Qualcomm chipsets) have "General Purpose"
>> clocks that can be muxed to GPIO outputs and used as PWM outputs.
>> Those outputs may be connected to various peripherals such as
>> leds in display backlight or haptic feedback motor driver.
>>
>> To avoid re-implementing every single PWM consumer driver with clk
>> support (like in [1]) and don't put the burden of providing the PWM
>> sources on the clock drivers (as was proposed in [2]), clk based
>> pwm controller driver is introduced.
>>
>> There is an existing driver that provides the opposite function
>> in drivers/clk/clk-pwm.c with a compatible "pwm-clock" so the new
>> driver uses the opposite naming scheme: drivers/pwm/pwm-clk.c
>> and compatible "clk-pwm".
> 
> You got some feedback on your patches and didn't respond to it. Are you
> interested to improve your patch set? If yes, I'm willing to review more
> deeply. If not, I'm not.
> 

Hi, I do intend on finishing this and getting the patches upstream
however I was very short on time for the last while and couldn't get
to it.

For this v2 I see the dt bindings check failure, I think it's the
regex in the core schema that was defined incorrectly but my attempt
to fix it has failed last time I tried it for some reason.
(Now looking at it one more time, I see that '^pwm(@.*|-[0-9a-f])*$'
only allows [a-f] and I just tried to move the * to the correct place)
I also see that I've used the wrong division with rounding macro.

I am planning to send a v3 a bit later with those fixed.

Sorry for delaying the response
Nikita 


> Best regards
> Uwe