Re: [PATCH] gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe

[Bartosz Golaszewski]

On Fri, Jan 14, 2022 at 7:48 AM Miaoqian Lin <linmq006@xxxxxxxxx> wrote:
>
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
>     int irq = platform_get_irq(pdev, 0);
>     if (irq < 0)
>         return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> ---
>  drivers/gpio/gpio-mpc8xxx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
> index 70d6ae20b1da..01634c8d27b3 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -388,8 +388,8 @@ static int mpc8xxx_probe(struct platform_device *pdev)
>         }
>
>         mpc8xxx_gc->irqn = platform_get_irq(pdev, 0);
> -       if (!mpc8xxx_gc->irqn)
> -               return 0;
> +       if (mpc8xxx_gc->irqn < 0)
> +               return mpc8xxx_gc->irqn;
>
>         mpc8xxx_gc->irq = irq_domain_create_linear(fwnode,
>                                                    MPC8XXX_GPIO_PINS,
> --
> 2.17.1
>

Queued for fixes, thanks!

Bart