Re: [PATCH] perf test: Test 73 Sig_trap fails on s390

From: John Garry
Date: Mon Jan 17 2022 - 10:39:44 EST


On 16/12/2021 15:48, Marco Elver wrote:

+

On Thu, 16 Dec 2021 at 16:15, Thomas Richter<tmricht@xxxxxxxxxxxxx> wrote:
In Linux next kernel
Commit 5504f67944484 ("perf test sigtrap: Add basic stress test for sigtrap handling")
introduced the new test which uses breakpoint events.
These events are not supported on s390 and PowerPC and always fail:

# perf test -F 73
73: Sigtrap : FAILED!
#

Fix it the same way as in the breakpoint tests in file
tests/bp_account.c where these type of tests are skipped on
s390 and PowerPC platforms.

With this patch skip this test on both platforms.

Output after:
# ./perf test -F 73
73: Sigtrap

Fixes: 5504f67944484 ("perf test sigtrap: Add basic stress test for sigtrap handling")

Cc: Marco Elver<elver@xxxxxxxxxx>
Signed-off-by: Thomas Richter<tmricht@xxxxxxxxxxxxx>
Acked-by: Marco Elver<elver@xxxxxxxxxx>

Thanks, and sorry for missing this case!


I am finding that this test hangs on my arm64 machine:

john@debian:~/kernel-dev2/tools/perf$ sudo ./perf test -vvv 73
73: Sigtrap:
--- start ---
test child forked, pid 45193

And fails on my x86 broadwell machine:

john@localhost:~/kernel-dev2/tools/perf> sudo ./perf test -v 73
73: Sigtrap :
--- start ---
test child forked, pid 22255
FAILED sys_perf_event_open(): Argument list too long
test child finished with -1
---- end ----
Sigtrap: FAILED!
john@localhost:~/kernel-dev2/tools/perf>

Are there more architectures+platforms for which we need to skip this test?

Thanks,
John