Re: [PATCH v8 03/13] rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl

[Arnaud POULIQUEN]

Hello Bjorn,

On 1/17/22 11:55 PM, Bjorn Andersson wrote:
> On Tue 07 Dec 02:08 CST 2021, Arnaud Pouliquen wrote:
> > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
> [..]
> > -static void rpmsg_ctrldev_release_device(struct device *dev)
> > -{
> > -	struct rpmsg_ctrldev *ctrldev = dev_to_ctrldev(dev);
> > -
> > -	ida_simple_remove(&rpmsg_ctrl_ida, dev->id);
> > -	ida_simple_remove(&rpmsg_minor_ida, MINOR(dev->devt));
> > -	cdev_del(&ctrldev->cdev);
> > -	kfree(ctrldev);
> > -}
> > -
> > -static int rpmsg_chrdev_probe(struct rpmsg_device *rpdev)
> > -{
> > -	struct rpmsg_ctrldev *ctrldev;
> > -	struct device *dev;
> > -	int ret;
> > -
> > -	ctrldev = kzalloc(sizeof(*ctrldev), GFP_KERNEL);
> > -	if (!ctrldev)
> > -		return -ENOMEM;
> > -
> > -	ctrldev->rpdev = rpdev;
> > -
> > -	dev = &ctrldev->dev;
> > -	device_initialize(dev);
> > -	dev->parent = &rpdev->dev;
> > -	dev->class = rpmsg_class;
> > -
> > -	cdev_init(&ctrldev->cdev, &rpmsg_ctrldev_fops);
> > -	ctrldev->cdev.owner = THIS_MODULE;
> > -
> > -	ret = ida_simple_get(&rpmsg_minor_ida, 0, RPMSG_DEV_MAX, GFP_KERNEL);
> > -	if (ret < 0)
> > -		goto free_ctrldev;
> > -	dev->devt = MKDEV(MAJOR(rpmsg_major), ret);
> > -
> > -	ret = ida_simple_get(&rpmsg_ctrl_ida, 0, 0, GFP_KERNEL);
> > -	if (ret < 0)
> > -		goto free_minor_ida;
> > -	dev->id = ret;
> > -	dev_set_name(&ctrldev->dev, "rpmsg_ctrl%d", ret);
> > -
> > -	ret = cdev_add(&ctrldev->cdev, dev->devt, 1);
>
> This turns out to be incomplete and the cdev_del above is in the wrong
> place. This, and the same for eptdev, is being corrected in:
>
> https://lore.kernel.org/linux-remoteproc/164245960510.1698571.4998090450663669237.b4-ty@xxxxxxxxxx/T/#t

I will rebase on next branch including this patchset

Thanks,
Arnaud

> Regards,
> Bjorn