Re: [PATCH net-next v12 7/7] net: dt-bindings: dwmac: add support for mt8195
From: Biao Huang
Date: Tue Jan 18 2022 - 20:21:33 EST
Dear Rob,
Thanks for your comments.
If patch "[PATCH net-next v12 4/7] arm64: dts: mt2712: update
ethernet device node" is applied with dt-binding patches, "make
dtbs_check" will not report
such warnings.
Please review it kindly, thanks.
On Mon, 2022-01-17 at 09:35 -0600, Rob Herring wrote:
> On Mon, 17 Jan 2022 15:07:06 +0800, Biao Huang wrote:
> > Add binding document for the ethernet on mt8195.
> >
> > Signed-off-by: Biao Huang <biao.huang@xxxxxxxxxxxx>
> > ---
> > .../bindings/net/mediatek-dwmac.yaml | 28
> > ++++++++++++++++---
> > 1 file changed, 24 insertions(+), 4 deletions(-)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for
> dtbs_check.
> This will change in the future.
>
> Full log is available here:
> https://patchwork.ozlabs.org/patch/1580608
>
>
> ethernet@1101c000: clock-names: ['axi', 'apb', 'mac_main', 'ptp_ref']
> is too short
> arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml
>
> ethernet@1101c000: clocks: [[27, 34], [27, 37], [6, 154], [6, 155]]
> is too short
> arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml
>
> ethernet@1101c000: compatible: ['mediatek,mt2712-gmac'] does not
> contain items matching the given schema
> arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml
>
> ethernet@1101c000: compatible: 'oneOf' conditional failed, one must
> be fixed:
> arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml
>
> ethernet@1101c000: Unevaluated properties are not allowed
> ('compatible', 'reg', 'interrupts', 'interrupt-names', 'mac-address',
> 'clock-names', 'clocks', 'power-domains', 'snps,axi-config',
> 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,txpbl',
> 'snps,rxpbl', 'clk_csr', 'phy-mode', 'phy-handle', 'snps,reset-gpio',
> 'mdio' were unexpected)
> arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml
>