Re: [RESEND][PATCH] checkpatch: make sure fix-up patches have Fixes tag

[Andy Whitcroft]

On Wed, Jan 19, 2022 at 9:42 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Wed, 2022-01-19 at 16:46 +0900, Sergey Senozhatsky wrote:
> > If a patch contains "commit hash (commit name)", in other words
> > if the patch fixes some particular commit, then require "Fixes:"
> > tag.
>
> I do not like this patch as many commits merely reference a
> previous patch and do not actually fix anything.

Agree.  It would need to be a tighter form of language to be safe to
automatically suggest a Fixes tag.  The point of a Fixes tag is to be
a semantically safe indicator of this relationship not relying on the
vagaries of English for that connection.

You might be ok with something which is a tighter match on like
"fixes <hash> (<name>)" and only suggesting a Fixes.

-apw