Re: [PATCH v3 1/4] Watchdog: sp5100_tco: Move timer initialization into function

[Andy Shevchenko]

On Tue, Jan 18, 2022 at 10:22 PM Terry Bowman <terry.bowman@xxxxxxx> wrote:
>
> Refactor driver's timer initialization into new function. This is needed
> inorder to support adding new device layouts while using common timer
> initialization.

> Co-developed-by: Robert Richter <rrichter@xxxxxxx>
> Signed-off-by: Robert Richter <rrichter@xxxxxxx>
> Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx>

> To: Guenter Roeck <linux@xxxxxxxxxxxx>
> To: linux-watchdog@xxxxxxxxxxxxxxx
> To: Jean Delvare <jdelvare@xxxxxxxx>
> To: linux-i2c@xxxxxxxxxxxxxxx
> To: Wolfram Sang <wsa@xxxxxxxxxx>
> To: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> To: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>
> Cc: Robert Richter <rrichter@xxxxxxx>
> Cc: Thomas Lendacky <thomas.lendacky@xxxxxxx>

Please, do not pollute commit messages with this rather unnecessary
list of recipients. There are (at least?) two possibilities:
- use --cc and --to whe run `git send-email`
- move them under the cutter '--- ' line below

> ---

> +       val = readl(SP5100_WDT_CONTROL(tco->tcobase));
> +       if (val & SP5100_WDT_DISABLED) {
> +               dev_err(dev, "Watchdog hardware is disabled\n");
> +               return(-ENODEV);

Missed space, too many parentheses.

> +       }

-- 
With Best Regards,
Andy Shevchenko