Re: [PATCH v4 5/9] platform/x86: i2c-multi-instantiate: Rename it for a generic bus driver name
From: Hans de Goede
Date: Thu Jan 20 2022 - 13:39:33 EST
Hi,
On 1/20/22 19:34, Rafael J. Wysocki wrote:
> On Thu, Jan 20, 2022 at 2:43 PM Stefan Binding
> <sbinding@xxxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> From: Lucas Tanure <tanureal@xxxxxxxxxxxxxxxxxxxxx>
>>
>> Rename I2C multi instantiate driver to bus-multi-instantiate for
>> upcoming addition of SPI support
>
> TBH, I don't particularly like the new naming.
>
> Namely, the "bus" part seems overly generic (and the "bmi"
> abbreviation brings something totally different to mind).
>
> AFAICS this can cover serial interfaces only and specifically the ones
> where serial links can be represented as resources returned by the
> ACPI _CRS object.
>
> I would call it serial-multi-instance or similar.
serial-multi-instantiate works for me. That also nice matches
up with the ACPI_RESOURCE_TYPE_SERIAL_BUS which acpi/scan.c
uses to detect these kinda resources.
Regards,
Hans