RE: [PATCH v6 1/2] spi: Add spi driver for Sunplus SP7021

From: Lh Kuo 郭力豪
Date: Fri Jan 21 2022 - 01:55:15 EST


> > > > + if (xfer->tx_buf)
> > > > + dma_unmap_single(dev, xfer->tx_dma, xfer->len, DMA_TO_DEVICE);
> > > > + if (xfer->rx_buf)
> > > > + dma_unmap_single(dev, xfer->rx_dma, xfer->len,
> > > > + DMA_FROM_DEVICE);
> > >
> > > Why can't you use SPI core DMA mapping code?
> >
> > I didn't find the SPI core DMA mapping code for single maping.
> > The method currently used is the general DMA single-map code usage method.
>
> Why do you need single page mapping?
> What's wrong with SG mapping that SPI core provides?

SP7021 SPI slave dma only supports single dma in one trigger.
It is not suitable for using SG mapping.
If the length of the transfer is larger than the length of the SG-mapping,
Slave-mode will get error in the transfer.