RE: [PATCH v3] rtw88: check for validity before using a pointer

[Pkshih]

> -----Original Message-----
> From: Pkshih <pkshih@xxxxxxxxxxx>
> Sent: Friday, December 24, 2021 5:01 PM
> To: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>; Yan-Hsuan Chuang <tony0620emma@xxxxxxxxx>; Kalle
> Valo <kvalo@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Bernie
> Huang <phhuang@xxxxxxxxxxx>; open list:REALTEK WIRELESS DRIVER (rtw88) <linux-wireless@xxxxxxxxxxxxxxx>;
> open list:NETWORKING DRIVERS <netdev@xxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>
> Cc: kernel@xxxxxxxxxxxxx
> Subject: RE: [PATCH v3] rtw88: check for validity before using a pointer
> 
> > -----Original Message-----
> > From: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
> > Sent: Friday, December 24, 2021 4:55 PM
> > To: Yan-Hsuan Chuang <tony0620emma@xxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxx>; David S. Miller
> > <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Pkshih <pkshih@xxxxxxxxxxx>; Bernie Huang
> > <phhuang@xxxxxxxxxxx>; open list:REALTEK WIRELESS DRIVER (rtw88) <linux-wireless@xxxxxxxxxxxxxxx>; open
> > list:NETWORKING DRIVERS <netdev@xxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>
> > Cc: usama.anjum@xxxxxxxxxxxxx; kernel@xxxxxxxxxxxxx
> > Subject: [PATCH v3] rtw88: check for validity before using a pointer
> >
> > ieee80211_probereq_get() can return NULL. Pointer skb should be checked
> > for validty before use. If it is not valid, list of skbs needs to be
> > freed.
> >
> > Fixes: 10d162b2ed39 ("rtw88: 8822c: add ieee80211_ops::hw_scan")
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
> 
> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> 
> [...]
> 

I take this patch into my patchset [1], because my new patches are based this patch
related to fixes of hw_scan.

[1] https://lore.kernel.org/linux-wireless/20220121070813.9656-2-pkshih@xxxxxxxxxxx/T/#u

--
Ping-Ke