Re: [PATCH v2 26/35] brcmfmac: cfg80211: Pass the PMK in binary instead of hex

[Arend van Spriel]

On 1/4/2022 8:26 AM, Hector Martin wrote:
> Apparently the hex passphrase mechanism does not work on newer
> chips/firmware (e.g. BCM4387). It seems there was a simple way of
> passing it in binary all along, so use that and avoid the hexification.
>
> OpenBSD has been doing it like this from the beginning, so this should
> work on all chips.
>
> Also clear the structure before setting the PMK. This was leaking
> uninitialized stack contents to the device.
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
> Signed-off-by: Hector Martin <marcan@xxxxxxxxx>
> ---
>   .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature