Re: [PATCH] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI

[Jason A. Donenfeld]

On Fri, Jan 21, 2022 at 8:54 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> There are some lines over 80 columns in this patch.

I'll fix that up.

> Otherwise this looks fine.  It would be really nice to fix this in clang,
> though.

I agree. I'm wondering whether it makes sense to roll with this patch,
or to just not change anything and lean on Clang upstream to fix their
bug. Full LTO is marked as "experimental" still. On the other hand,
Android ships with it turned on, so how "experimental" can it really
be? I don't have a strong read on the Clang ecosystem to know what
makes most sense, to apply this or not. Do you have an opinion?

Jason