Re: [PATCH v3 1/2] iio: adc: tsc2046: add .read_raw support

From: Oleksij Rempel
Date: Mon Jan 24 2022 - 02:08:24 EST


Hi Jonathan,

On Sat, Jan 22, 2022 at 05:14:20PM +0000, Jonathan Cameron wrote:
> On Mon, 17 Jan 2022 09:28:51 +0100
> Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>
> > Add read_raw() support to make use of iio_hwmon and other iio clients.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>
> > ---
>
> Change log? If it's just the check against PAGE_SIZE then I'm fine with it, but
> maybe I missed something.

yes, only PAGE_SIZE.

> Much better to have a short description of what
> changed here.

OK

> Anyhow, I'll assume that's it. Applied to the togreg branch of iio.git and
> pushed out as testing to let 0-day poke at it and see if it can find any
> problems.
>
> There was a little fuzz here for patch 2, presumably because the fix that is
> in flight. Hopefully that won't cause us too many problems in linux-next or
> at merge time.

Thank you!

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |