Re: [PATCH] erofs: fix fsdax partition offset handling

From: Gao Xiang
Date: Mon Jan 24 2022 - 03:34:09 EST


On Mon, Jan 24, 2022 at 03:11:35PM +0800, Chao Yu wrote:
> On 2022/1/13 13:18, Gao Xiang wrote:
> > After seeking time on testing today upstream fsdax, I found it
> > actually doesn't work well as below:
> >
> > [ 186.492983] ------------[ cut here ]------------
> > [ 186.493629] WARNING: CPU: 1 PID: 205 at fs/iomap/iter.c:33 iomap_iter+0x2f6/0x310
> >
> > The problem is that m_dax_part_off should be applied to physical
> > addresses and very sorry about that I didn't catch this eariler.
> >
> > Anyway, let's fix it up now. Also, I need to find a way to set up
> > a standalone testcase to look after this later.
> >
> > Fixes: de2051147771 ("fsdax: shift partition offset handling into the file systems")
> > Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Chao Yu <chao@xxxxxxxxxx>

Thanks for the review! I will send this together with other misc
fixes this or next week..

Thanks,
Gao Xiang

>
> Thanks,