Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

From: Javier Martinez Canillas
Date: Mon Jan 24 2022 - 06:51:02 EST


On 1/24/22 12:33, Thomas Zimmermann wrote:

[snip]

>> Thoughts?
>
> I can't say I approve keeping fbdev alive, but...
>
> With fbdev emulation, every DRM driver is an fbdev driver too. So
> CONFIG_FB_DRIVER is somewhat misleading. Better add an option like
> CONFIG_FBCON_HW_SCROLLING and have it selected by the fbdev drivers that
> absolutely need HW acceleration. That option would then protect the rsp
> code.
>

Agreed that this option would be better and allow distros
to disable the code that was reverted.

Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat