Re: [PATCH 27/54] lib/bitmap: add bitmap_weight_{cmp, eq, gt, ge, lt, le} functions

From: Andy Shevchenko
Date: Mon Jan 24 2022 - 07:44:45 EST

On Mon, Jan 24, 2022 at 02:41:38PM +0200, Andy Shevchenko wrote:
> On Sun, Jan 23, 2022 at 10:38:58AM -0800, Yury Norov wrote:

...

> > + if (num > (int)nbits || num < 0)
>
> Wonder if
>
> if (abs(num) > nbits)
>
> would be sufficient.

Scratch it. Of course it won't work.

It may be other way around:

if ((unsigned int)num > nbits)

> > + return -num;

--
With Best Regards,
Andy Shevchenko