Re: [PATCH 10/11] serial: make uart_console_write->putchar()'s character a char
From: kernel test robot
Date: Mon Jan 24 2022 - 09:31:14 EST
Hi Jiri,
I love your patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v5.17-rc1 next-20220124]
[cannot apply to shawnguo/for-next davem-sparc/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jiri-Slaby/TTY-patches-for-5-18/20220124-151758
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: microblaze-randconfig-r006-20220124 (https://download.01.org/0day-ci/archive/20220124/202201242255.WTSwb6EN-lkp@xxxxxxxxx/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/45520d4f6db241db0b77f41162adba4a9977956c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jiri-Slaby/TTY-patches-for-5-18/20220124-151758
git checkout 45520d4f6db241db0b77f41162adba4a9977956c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/tty/serial/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/tty/serial/sprd_serial.c: In function 'sprd_console_write':
>> drivers/tty/serial/sprd_serial.c:1007:44: error: passing argument 4 of 'uart_console_write' from incompatible pointer type [-Werror=incompatible-pointer-types]
1007 | uart_console_write(port, s, count, sprd_console_putchar);
| ^~~~~~~~~~~~~~~~~~~~
| |
| void (*)(struct uart_port *, int)
In file included from drivers/tty/serial/sprd_serial.c:18:
include/linux/serial_core.h:402:32: note: expected 'void (*)(struct uart_port *, char)' but argument is of type 'void (*)(struct uart_port *, int)'
402 | void (*putchar)(struct uart_port *, char));
| ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/uart_console_write +1007 drivers/tty/serial/sprd_serial.c
b7396a38fb28db Chunyan Zhang 2015-01-28 992
b7396a38fb28db Chunyan Zhang 2015-01-28 993 static void sprd_console_write(struct console *co, const char *s,
b7396a38fb28db Chunyan Zhang 2015-01-28 994 unsigned int count)
b7396a38fb28db Chunyan Zhang 2015-01-28 995 {
b7396a38fb28db Chunyan Zhang 2015-01-28 996 struct uart_port *port = &sprd_port[co->index]->port;
b7396a38fb28db Chunyan Zhang 2015-01-28 997 int locked = 1;
b7396a38fb28db Chunyan Zhang 2015-01-28 998 unsigned long flags;
b7396a38fb28db Chunyan Zhang 2015-01-28 999
b7396a38fb28db Chunyan Zhang 2015-01-28 1000 if (port->sysrq)
b7396a38fb28db Chunyan Zhang 2015-01-28 1001 locked = 0;
b7396a38fb28db Chunyan Zhang 2015-01-28 1002 else if (oops_in_progress)
b7396a38fb28db Chunyan Zhang 2015-01-28 1003 locked = spin_trylock_irqsave(&port->lock, flags);
b7396a38fb28db Chunyan Zhang 2015-01-28 1004 else
b7396a38fb28db Chunyan Zhang 2015-01-28 1005 spin_lock_irqsave(&port->lock, flags);
b7396a38fb28db Chunyan Zhang 2015-01-28 1006
b7396a38fb28db Chunyan Zhang 2015-01-28 @1007 uart_console_write(port, s, count, sprd_console_putchar);
b7396a38fb28db Chunyan Zhang 2015-01-28 1008
b7396a38fb28db Chunyan Zhang 2015-01-28 1009 /* wait for transmitter to become empty */
b7396a38fb28db Chunyan Zhang 2015-01-28 1010 wait_for_xmitr(port);
b7396a38fb28db Chunyan Zhang 2015-01-28 1011
b7396a38fb28db Chunyan Zhang 2015-01-28 1012 if (locked)
b7396a38fb28db Chunyan Zhang 2015-01-28 1013 spin_unlock_irqrestore(&port->lock, flags);
b7396a38fb28db Chunyan Zhang 2015-01-28 1014 }
b7396a38fb28db Chunyan Zhang 2015-01-28 1015
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx