Re: [PATCH v1] scsi: ufs: disable auto hibern8 while entering suspend

From: kernel test robot
Date: Mon Jan 24 2022 - 10:43:15 EST


Hi SEO,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linux/master linus/master v5.17-rc1 next-20220124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/SEO-HOYOUNG/scsi-ufs-disable-auto-hibern8-while-entering-suspend/20220124-195745
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: arc-randconfig-r043-20220124 (https://download.01.org/0day-ci/archive/20220124/202201242328.jXmzUj9v-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/07442fb1071785299ef4ec421a37874e0d84babf
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review SEO-HOYOUNG/scsi-ufs-disable-auto-hibern8-while-entering-suspend/20220124-195745
git checkout 07442fb1071785299ef4ec421a37874e0d84babf
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/scsi/ufs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/scsi/ufs/ufshcd.c:4207:6: warning: no previous prototype for 'ufshcd_auto_hibern8_disable' [-Wmissing-prototypes]
4207 | void ufshcd_auto_hibern8_disable(struct ufs_hba *hba)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/ufshcd_auto_hibern8_disable +4207 drivers/scsi/ufs/ufshcd.c

4206
> 4207 void ufshcd_auto_hibern8_disable(struct ufs_hba *hba)
4208 {
4209 unsigned long flags;
4210
4211 if (!ufshcd_is_auto_hibern8_supported(hba))
4212 return;
4213
4214 spin_lock_irqsave(hba->host->host_lock, flags);
4215 ufshcd_writel(hba, 0, REG_AUTO_HIBERNATE_IDLE_TIMER);
4216 spin_unlock_irqrestore(hba->host->host_lock, flags);
4217 }
4218

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx