RE: [PATCH v2 3/3] arm64: dts: fsd: Add SPI device nodes

From: Alim Akhtar
Date: Mon Jan 24 2022 - 12:01:16 EST


Thanks Andi for review

>-----Original Message-----
>From: Andi Shyti [mailto:andi@xxxxxxxxxxx]
>Sent: Saturday, January 22, 2022 4:13 PM
>To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>devicetree@xxxxxxxxxxxxxxx; linus.walleij@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
>krzysztof.kozlowski@xxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx;
>pankaj.dubey@xxxxxxxxxxx; broonie@xxxxxxxxxx; andi@xxxxxxxxxxx; linux-
>spi@xxxxxxxxxxxxxxx; Aswani Reddy <aswani.reddy@xxxxxxxxxxx>; linux-
>fsd@xxxxxxxxx
>Subject: Re: [PATCH v2 3/3] arm64: dts: fsd: Add SPI device nodes
>
>Hi Alim and Aswani,
>
>On Fri, Jan 21, 2022 at 12:54:38AM +0530, Alim Akhtar wrote:
>> From: Aswani Reddy <aswani.reddy@xxxxxxxxxxx>
>>
>> Adds device tree node for SPI IPs
>>
>> Cc: linux-fsd@xxxxxxxxx
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>> Signed-off-by: Aswani Reddy <aswani.reddy@xxxxxxxxxxx>
>> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>
>Reviewed-by: Andi Shyti <andi@xxxxxxxxxxx>
>
>Please, also allow me another nit-commnent for the next patches:
>the tag section is in chronological order. I suppose that first Aswani
wrote the
>patch, then you sent it to the mailing list and at the end Krzysztof has
>reviewed it, this means that the right order is:
>
> Signed-off-by: Aswani Reddy <aswani.reddy@xxxxxxxxxxx>
> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>
Sure, will update it in the next version of the patch set.

>Thank you,
>Andi