Re: [PATCH 01/60] drm/komeda: Add support for the nomodeset kernel parameter

[Carsten Haitzler]

Seems fine.

Reviewed-by: Carsten Haitzler <carsten.haitzler@xxxxxxx>

On 12/15/21 00:59, Javier Martinez Canillas wrote:
> According to disable Documentation/admin-guide/kernel-parameters.txt, this
> parameter can be used to disable kernel modesetting.
>
> DRM drivers will not perform display-mode changes or accelerated rendering
> and only the systewm system framebuffer will be available if it was set-up.
>
> But only a few DRM drivers currently check for nomodeset, make this driver
> to also support the command line parameter.
>
> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> ---
>
>   drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> index e7933930a657..4f6d5c2103ec 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> @@ -9,6 +9,7 @@
>   #include <linux/platform_device.h>
>   #include <linux/component.h>
>   #include <linux/pm_runtime.h>
> +#include <drm/drm_drv.h>
>   #include <drm/drm_of.h>
>   #include "komeda_dev.h"
>   #include "komeda_kms.h"
> @@ -117,6 +118,9 @@ static int komeda_platform_probe(struct platform_device *pdev)
>   	struct component_match *match = NULL;
>   	struct device_node *child;
>   
> +	if (drm_firmware_drivers_only())
> +		return -EINVAL;
> +
>   	if (!dev->of_node)
>   		return -ENODEV;
>