Re: [PATCH net-next] net-core: add InMacErrors counter

[Jakub Kicinski]

On Mon, 24 Jan 2022 09:39:22 -0800 Eric Dumazet wrote:
> On Mon, Jan 24, 2022 at 9:29 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> 
> > That much it's understood, but it's a trade off. This drop point
> > existed for 20 years, why do we need to consume extra memory now?  
> 
> Being able to tell after the facts, that such a drop reason had
> occured can help investigations.
> 
> nstat -a | grep InMac
> 
> Jeffrey, what about _also_ adding the kfree_skb_reason(), since this
> seems to also help ?

Yes, and please add a proper justification to the commit message, 
with real life examples of cases where this drop point has proven
to be the culprit. Right now the commit message says gives the example
of trafgen :(