Re: [PATCH] btrfs: initialize variable cancel

From: David Sterba
Date: Mon Jan 24 2022 - 21:34:06 EST


On Fri, Jan 21, 2022 at 05:45:22AM -0800, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
>
> Clang static analysis reports this problem
> ioctl.c:3333:8: warning: 3rd function call argument is an
> uninitialized value
> ret = exclop_start_or_cancel_reloc(fs_info,
>
> cancel is only set in one branch of an if-check and is
> always used. So initialize to false.
>
> Fixes: 1a15eb724aae ("btrfs: use btrfs_get_dev_args_from_path in dev removal ioctls")
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Added to misc-next, with the updted subject line, thanks.