Re: [PATCH 7/7] iommu: Add iommu_domain::domain_ops

[Lu Baolu]

On 1/25/22 1:24 AM, Jason Gunthorpe wrote:
> On Mon, Jan 24, 2022 at 01:37:21AM -0800, Christoph Hellwig wrote:
> > On Mon, Jan 24, 2022 at 03:11:02PM +0800, Lu Baolu wrote:
> > > Add a domain specific callback set, domain_ops, for vendor iommu driver
> > > to provide domain specific operations. Move domain-specific callbacks
> > > from iommu_ops to the domain_ops and hook them when a domain is allocated.
> >
> > Ah, that's what I meant earlier.  Perfect!
> >
> > Nit:  I don't think vendor is the right term here.
>
> +1 please don't use the confusing 'vendor' in the kernel, if you feel
> you want to write 'vendor' writing 'device driver' is usually a good
> choice..

Sure!

> This whole series is nice, the few small notes aside, thanks for
> making it!

Thank you!

> Jason

Best regards,
baolu