Re: Re: [PATCH v8 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes

From: Macpaul Lin
Date: Tue Jan 25 2022 - 03:37:59 EST



On 6/16/21 10:07 PM, Hsin-hsiung Wang wrote:
Hi,

On Fri, 2021-06-11 at 16:09 +0200, Matthias Brugger wrote:

On 26/05/2021 08:52, Hsin-Hsiung Wang wrote:
From: Wen Su <wen.su@xxxxxxxxxxxx>

add PMIC MT6359 related nodes which is for MT6779 platform

Signed-off-by: Wen Su <wen.su@xxxxxxxxxxxx>
Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@xxxxxxxxxxxx>
---
changes since v7:
- no change.
---
arch/arm64/boot/dts/mediatek/mt6359.dtsi | 298 ++++++++++++++++++++++++++++
arch/arm64/boot/dts/mediatek/mt8192-evb.dts | 1 +
2 files changed, 299 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt6359.dtsi

diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
new file mode 100644
index 0000000..18c0d53
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
@@ -0,0 +1,298 @@
+// SPDX-License-Identifier: GPL-2.0

Any specific reason for not setting it "SPDX-License-Identifier: (GPL-2.0+ OR
MIT)" ?

Other then that, looks good.

Matthias


Thanks for the review, there is no special reason for the writing.
I will update it in the next patch.

[The content of the patch has been deleted...]

According to the reviewing note of PMIC wrap, URL:
https://patchwork.kernel.org/project/linux-mediatek/cover/1615563286-22126-1-git-send-email-hsin-hsiung.wang@xxxxxxxxxxxx

Dear Hui and Sen,
could you help update and upstream the mt6359.dtsi and mt8192-evb.dts with the necessary fixes?

Thanks!
Macpaul Lin