Re: [PATCH v9] net: bonding: Add support for IPV6 ns/na to balance-alb/balance-tlb mode

[孙守鑫]

在 2022/1/25 17:02, Nikolay Aleksandrov 写道:
> On 25/01/2022 10:51, Nikolay Aleksandrov wrote:
> > On 25/01/2022 04:37, Sun Shouxin wrote:
> > > Since ipv6 neighbor solicitation and advertisement messages
> > > isn't handled gracefully in bond6 driver, we can see packet
> > > drop due to inconsistency between mac address in the option
> > > message and source MAC .
> > >
> > > Another examples is ipv6 neighbor solicitation and advertisement
> > > messages from VM via tap attached to host bridge, the src mac
> > > might be changed through balance-alb mode, but it is not synced
> > > with Link-layer address in the option message.
> > >
> > > The patch implements bond6's tx handle for ipv6 neighbor
> > > solicitation and advertisement messages.
> > >
> > > Suggested-by: Hu Yadi <huyd12@xxxxxxxxxxxxxxx>
> > > Acked-by: Jay Vosburgh <jay.vosburgh@xxxxxxxxxxxxx>
> > > Signed-off-by: Sun Shouxin <sunshouxin@xxxxxxxxxxxxxxx>
> > > ---
> > >   drivers/net/bonding/bond_alb.c | 38 +++++++++++++++++++++++++++++++++-
> > >   1 file changed, 37 insertions(+), 1 deletion(-)
> [snip]
>
> Also forgot to mention, you should add a changelog between patch versions.
> You can add it below the --- marker so it won't be included in the commit
> message. Otherwise it's hard to track how the patch reached v9 and what
> changed between versions.
>
> E.g. v8 -> v9: <changed blah>
>
> Thanks,
>   Nik

Thanks your comment, I'll adjust it and send out V10 soon.