Re: [PATCH 05/16] scsi: libsas: Add struct sas_tmf_task

From: John Garry
Date: Tue Jan 25 2022 - 09:10:35 EST


On 25/01/2022 13:37, Matthew Wilcox wrote:
Also add an interim force phy id field for hisi_sas driver, which will be
removed once the STP "TMF" code is factored out.

Even though some LLDDs (pm8001) use a u32 for the tag, u16 should be
enough.
... because pm8001 limits the number of tags to 1024.
.

Sure, but the pm8001 HW does has a 32b field, which is strange as the SAS spec defines a 16b field in the task management Function information unit "tag of task to be managed" field.

Thanks,
John