Re: [PATCH 0/3] arm64: dts: meson: add BL32 reserved region to Beelink g12b devices

From: Neil Armstrong
Date: Tue Jan 25 2022 - 10:04:21 EST


Hi,

On 25/01/2022 05:02, Christian Hewitt wrote:
>
>> On 25 Jan 2022, at 12:02 am, Kevin Hilman <khilman@xxxxxxxxxxxx <mailto:khilman@xxxxxxxxxxxx>> wrote:
>>
>> Christian Hewitt <christianshewitt@xxxxxxxxx <mailto:christianshewitt@xxxxxxxxx>> writes:
>>
>>> This resolves a long-running issue where Beelink GT-King/Pro and
>>> GS-King-X wedge on boot or shortly after when booting from vendor
>>> u-boot. In some distros the issue is often reported as triggered
>>> by large file transfers to/from USB or SD cards. Reserving the
>>> BL32 memory region prevents the issue.
>>
>> The BL32 is typically common for the SoC family, so this change should
>> probably go into the g12b.dtsi.  Or probably even
>> meson-g12-common.dtsi, which is where the BL31 reserved-memory is
>> described.
>
> Hi Kevin,
>
> Would you be okay with the same change applied to GX devices too? - I
> normally have these two catch-all patches in my tree to deal with random
> tv box hardware and it would be great to drop them:
>
> https://github.com/chewitt/linux/commit/4315ea4612389fc08d0a008b562cafbda96374fc <https://github.com/chewitt/linux/commit/4315ea4612389fc08d0a008b562cafbda96374fc>
> https://github.com/chewitt/linux/commit/3c0df794baa7ea9d32d8ad54530b5a056c770ea9 <https://github.com/chewitt/linux/commit/3c0df794baa7ea9d32d8ad54530b5a056c770ea9>

Sure, it has been done in a similar way for bl31:
https://github.com/torvalds/linux/commit/48e21ded0432ee1e2359d4143d7a6925cefee1b5

in a perfect work we wouldn't need this since mainline U-Boot does the job by reserving these
memory zones, but vendor u-boot exists and isn't avoidable.

Neil

>
> Christian