Re: review for 5.16.3-rc2

[Greg KH]

On Tue, Jan 25, 2022 at 09:49:00PM +0530, Jeffrin Thalakkottoor wrote:
> On Tue, Jan 25, 2022 at 8:04 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Jan 25, 2022 at 06:15:46PM +0530, Jeffrin Jose T wrote:
> > > hello greg,
> > >
> > > compile failed for  5.16.3-rc2 related.
> > > a relevent file attached.
> > >
> > > Tested-by : Jeffrin Jose T <jeffrin@xxxxxxxxxxxxxxxxxxx>
> >
> > But it failed for you, how did you test it?
> 
> i compiled  5.16.3-rc2  related to "make localmodconfig" and  "make  -j4"

So it somehow failed?

> >
> > >
> > >
> >
> > >       char *                     typetab;              /*    24     8 */
> > >
> > >       /* size: 32, cachelines: 1, members: 4 */
> > >       /* sum members: 28, holes: 1, sum holes: 4 */
> > >       /* last cacheline: 32 bytes */
> > > };
> > > struct klp_modinfo {
> > >       Elf64_Ehdr                 hdr;                  /*     0    64 */
> > >       /* --- cacheline 1 boundary (64 bytes) --- */
> > >       Elf64_Shdr *               sechdrs;              /*    64     8 */
> > >       char *                     secstrings;           /*    72     8 */
> > >       unsigned int               symndx;               /*    80     4 */
> > >
> > >       /* size: 88, cachelines: 2, members: 4 */
> > >       /* padding: 4 */
> > >       /* last cacheline: 24 bytes */
> > > };
> > > Segmentation fault
> >
> > What "faulted"?  Look higher up in the log please.
> 
> a top view...
> 
>   CALL    scripts/atomic/check-atomics.sh
>   CALL    scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   GEN     .version
>   CHK     include/generated/compile.h
>   UPD     include/generated/compile.h
>   CC      init/version.o
>   AR      init/built-in.a
>   LD      vmlinux.o
>   MODPOST vmlinux.symvers
>   MODINFO modules.builtin.modinfo
>   GEN     modules.builtin
>   LD      .tmp_vmlinux.btf
>   BTF     .btf.vmlinux.bin.o
> struct list_head {
>     struct list_head *         next;                 /*     0     8 */
>     struct list_head *         prev;                 /*     8     8 */
> 
>     /* size: 16, cachelines: 1, members: 2 */
>     /* last cacheline: 16 bytes */
> };
> struct hlist_head {
>     struct hlist_node *        first;                /*     0     8 */
> 
>     /* size: 8, cachelines: 1, members: 1 */
>     /* last cacheline: 8 bytes */
> };
> struct hlist_node {
>     struct hlist_node *        next;                 /*     0     8 */
>     struct hlist_node * *      pprev;                /*     8     8 */
> 
>     /* size: 16, cachelines: 1, members: 2 */
>     /* last cacheline: 16 bytes */
> };
> struct callback_head {
>     struct callback_head *     next;                 /*     0     8 */
>     void                       (*func)(struct callback_head *); /*
> 8     8 */
> .
> .
> .
> .
> .
> .

I do not know what is failing, there is no error message here.  Does
5.16.2 build properly for you?

thanks,

greg k-h