Re: [PATCH] ACPICA: Use uintptr_t and offsetof() in Linux kernel builds

[Rafael J. Wysocki]

On Wed, Jan 12, 2022 at 9:45 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> On Tue, Jan 11, 2022 at 4:55 PM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
> >
> > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >
> > To avoid "performing pointer subtraction with a null pointer has
> > undefined behavior" compiler warnings, use uintptr_t and offsetof()
> > that are always available during Linux kernel builds to define
> > acpi_uintptr_t and the ACPI_TO_INTEGER() and ACPI_OFFSET() macros.
> >
> > Based on earlier proposal from Arnd Bergmann.
> >
> > Link: https://lore.kernel.org/linux-acpi/20210927121338.938994-1-arnd@xxxxxxxxxx
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Thanks for the follow-up. I can't easily test this at the moment, but
> it looks correct to
> me. I had a different approach that I had planned to eventually
> submit, but yours
> looks better anyway, so let's go with this.
>
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

Thank you, I've applied this patch as 5.18 material.

A pull request for the analogous change in the upstream code base has
been submitted and Bob is going to take it AFAICS.