Re: [PATCH][next] net: mana: Use struct_size() helper in mana_gd_create_dma_region()

From: Jakub Kicinski
Date: Tue Jan 25 2022 - 13:01:53 EST


On Mon, 24 Jan 2022 21:47:38 +0000 Dexuan Cui wrote:
> > From: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > Sent: Monday, January 24, 2022 1:44 PM
> > ...
> > Make use of the struct_size() helper instead of an open-coded version,
> > in order to avoid any potential type mistakes or integer overflows that,
> > in the worst scenario, could lead to heap overflows.
> >
> > Also, address the following sparse warnings:
> > drivers/net/ethernet/microsoft/mana/gdma_main.c:677:24: warning: using
> > sizeof on a flexible structure
> > ...
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>
> Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>

Thanks! Applied to net-next, 10cdc794dae8 ("net: mana: Use
struct_size() helper in mana_gd_create_dma_region()")