Re: [PATCH net-next 5/6] net: udp: use kfree_skb_reason() in udp_queue_rcv_one_skb()

From: David Ahern
Date: Tue Jan 25 2022 - 21:25:14 EST


On 1/24/22 6:15 AM, menglong8.dong@xxxxxxxxx wrote:
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 603f77ef2170..dd64a4f2ff1d 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -330,6 +330,7 @@ enum skb_drop_reason {
> SKB_DROP_REASON_UNICAST_IN_L2_MULTICAST,
> SKB_DROP_REASON_XFRM_POLICY,
> SKB_DROP_REASON_IP_NOPROTO,
> + SKB_DROP_REASON_UDP_FILTER,

Is there really a need for a UDP and TCP version? why not just:

/* dropped due to bpf filter on socket */
SKB_DROP_REASON_SOCKET_FILTER

> SKB_DROP_REASON_MAX,
> };
>