Re: [RESEND PATCH net-next 2/2] net: hns3: add ethtool priv-flag for TX push

From: Jakub Kicinski
Date: Tue Jan 25 2022 - 22:55:14 EST


On Tue, 25 Jan 2022 15:21:49 +0800 Guangbin Huang wrote:
> From: Yufeng Mo <moyufeng@xxxxxxxxxx>
>
> Add a control private flag in ethtool for enable/disable
> TX push feature.

I think it's a pretty standard feature for NICs which also support RDMA.
Mellanox/nVidia has it (or at least it the previous gen HW did),
Broadcom's bnxt driver does it as well.

Can we make this a standard knob via ethtool? Not entirely sure under
which switch, maybe it's okay to add it under -g? Perhaps we need a new
command similar to -k but for features contained entirely to the driver?