Re: [PATCH 3/4] staging: r8188eu: ODM_RF_CALIBRATION is always set

From: Dan Carpenter
Date: Wed Jan 26 2022 - 02:49:53 EST


On Sat, Jan 22, 2022 at 06:05:46PM +0100, Martin Kaiser wrote:
> @@ -36,10 +35,6 @@ static void Init_ODM_ComInfo_88E(struct adapter *Adapter)
> ODM_CmnInfoInit(dm_odm, ODM_CMNINFO_MP_TEST_CHIP, IS_NORMAL_CHIP(hal_data->VersionID));
>
> ODM_CmnInfoInit(dm_odm, ODM_CMNINFO_RF_ANTENNA_TYPE, hal_data->TRxAntDivType);
> -
> - pdmpriv->InitODMFlag = ODM_RF_CALIBRATION;
> -
> - ODM_CmnInfoUpdate(dm_odm, ODM_CMNINFO_ABILITY, pdmpriv->InitODMFlag);

Wait, why did you remove the ODM_CmnInfoUpdate()?

> }

regards,
dan carpenter